fix(plugin-npm): add resolver for converting locators with __archiveUrl #6891
+152
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spanishpear
force-pushed
the
fix/spanishpear/4711-patch-commmit-approach
branch
4 times, most recently
from
82988fc to
c02d930
Compare
spanishpear
changed the title
|
Thanks for adding tests to the PR! I'll close my previous PR as this PR solves the issues. |
3 tasks
|
@BasixKOR No worries! I think I tried to solve too much with this PR by also fixing patch-commit to generate valid selectors as well... big can of worms. I might try remove that second "fix" and just keep your original PR with the tests for now :D |
spanishpear
force-pushed
the
fix/spanishpear/4711-patch-commmit-approach
branch
from
2466d75 to
722e89c
Compare
spanishpear
changed the title
|
I've updated the PR to just add the tests, rather than try to fix the patch-package generation issue, as that's more complex. |
spanishpear
force-pushed
the
fix/spanishpear/4711-patch-commmit-approach
branch
from
722e89c to
70e7f70
Compare
spanishpear
force-pushed
the
fix/spanishpear/4711-patch-commmit-approach
branch
from
70e7f70 to
72906d6
Compare
spanishpear
changed the title
spanishpear
commented
Sep 28, 2025
There was a problem hiding this comment.
this is entirely from the original PR - this PR only adds tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's the problem this PR addresses?
This PR extends the tarball resolver started in #6525 and adds the tests requested!
Fixes #5156 #5890 (?)
How did you fix it?
1. New NpmTarballResolver
Added
packages/plugin-npm/sources/NpmTarballResolver.ts- a resolver that specifically handles npm packages with__archiveUrlparameters. Extended @BasixKOR's work from #6525 with testse.g. to handle
Checklist